feat(volo-http): add support for sse header validation#645
Open
Joshuahoky wants to merge 3 commits intocloudwego:mainfrom
Open
feat(volo-http): add support for sse header validation#645Joshuahoky wants to merge 3 commits intocloudwego:mainfrom
Joshuahoky wants to merge 3 commits intocloudwego:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
+ Coverage 43.98% 44.15% +0.17%
==========================================
Files 161 161
Lines 19750 19822 +72
==========================================
+ Hits 8687 8753 +66
- Misses 11063 11069 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a43b011 to
7e3a418
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Current implementation of sse has no validation of the Accept header on the server side
Solution
Added ResponseExt trait with is_sse() for checking if a response has Content-Type: text/event-stream
Added Accept header validation in Endpoint::call