Skip to content

feat(volo-http): add support for sse header validation#645

Open
Joshuahoky wants to merge 3 commits intocloudwego:mainfrom
Joshuahoky:feat/sse_header_check
Open

feat(volo-http): add support for sse header validation#645
Joshuahoky wants to merge 3 commits intocloudwego:mainfrom
Joshuahoky:feat/sse_header_check

Conversation

@Joshuahoky
Copy link
Copy Markdown
Collaborator

Motivation

Current implementation of sse has no validation of the Accept header on the server side

Solution

Added ResponseExt trait with is_sse() for checking if a response has Content-Type: text/event-stream
Added Accept header validation in Endpoint::call

@Joshuahoky Joshuahoky requested review from a team as code owners March 18, 2026 02:14
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.15%. Comparing base (ff310f7) to head (632acea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   43.98%   44.15%   +0.17%     
==========================================
  Files         161      161              
  Lines       19750    19822      +72     
==========================================
+ Hits         8687     8753      +66     
- Misses      11063    11069       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Joshuahoky Joshuahoky force-pushed the feat/sse_header_check branch from a43b011 to 7e3a418 Compare March 20, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant