Skip to content

feat(thrift): add fallback address option for shmipc#639

Merged
Joshuahoky merged 7 commits intocloudwego:mainfrom
Joshuahoky:feat/shmipc_fallback
Mar 16, 2026
Merged

feat(thrift): add fallback address option for shmipc#639
Joshuahoky merged 7 commits intocloudwego:mainfrom
Joshuahoky:feat/shmipc_fallback

Conversation

@Joshuahoky
Copy link
Copy Markdown
Collaborator

Motivation

Currently, volo-thrift supports shmipc transport for high-performance local communication but it may not be available or fail to connect. This PR introduces functionality which allows users to set a fallback address.

Solution

Added ShmipcMakeTransportWithFallback which wraps a DefaultMakeTransport

@Joshuahoky Joshuahoky requested review from a team as code owners February 9, 2026 06:36
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.66%. Comparing base (6220d5b) to head (d24d4ad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   43.72%   43.66%   -0.07%     
==========================================
  Files         161      161              
  Lines       19679    19679              
==========================================
- Hits         8604     8592      -12     
- Misses      11075    11087      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Joshuahoky Joshuahoky force-pushed the feat/shmipc_fallback branch from 0c35e94 to 9caec57 Compare March 11, 2026 01:55
@Joshuahoky Joshuahoky merged commit 6e8436c into cloudwego:main Mar 16, 2026
14 checks passed
@Joshuahoky Joshuahoky deleted the feat/shmipc_fallback branch March 27, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants