feat(thrift): add fallback address option for shmipc#639
Merged
Joshuahoky merged 7 commits intocloudwego:mainfrom Mar 16, 2026
Merged
feat(thrift): add fallback address option for shmipc#639Joshuahoky merged 7 commits intocloudwego:mainfrom
Joshuahoky merged 7 commits intocloudwego:mainfrom
Conversation
PureWhiteWu
reviewed
Feb 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 43.72% 43.66% -0.07%
==========================================
Files 161 161
Lines 19679 19679
==========================================
- Hits 8604 8592 -12
- Misses 11075 11087 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shenyj3
reviewed
Feb 9, 2026
a3dfde5 to
84d2d9d
Compare
0c35e94 to
9caec57
Compare
shenyj3
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, volo-thrift supports shmipc transport for high-performance local communication but it may not be available or fail to connect. This PR introduces functionality which allows users to set a fallback address.
Solution
Added ShmipcMakeTransportWithFallback which wraps a DefaultMakeTransport