Fix dotnet9 eol and angular lockfile#1256
Merged
Merged
Conversation
When t.Skip is called inside an it body, runtime.Goexit() fires after it.Before has already run and it.After is already deferred. The deferred it.After then calls platform.Delete.Execute, but since platform.Deploy was never called (we skipped before it), the per-test CF context is uninitialized and cf delete-org fails with 'No API endpoint set'. Moving t.Skip to it.Before is consistent with the SkipOnCflinuxfs3 pattern: when skip fires from it.Before, it.After has not yet been registered and therefore does not run.
t.Skip (even from it.Before) still triggers the outer it.After cleanup, which calls platform.Delete.Execute on an org that was never initialized by platform.Deploy.Execute, causing 'No API endpoint set' failures. it.Pend marks the spec as pending at registration time — no it.Before or it.After hooks fire for it at all, so cleanup is never attempted.
The it.Before was removed when switching to it.Pend, but keeping it makes the test self-contained: when the segfault is fixed and it.Pend is changed back to it, no other edits are needed.
tnikolova82
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use it.Pend instead of t.Skip for .NET Core 9 test t.Skip (even from it.Before) still triggers the outer it.After cleanup,
which calls platform.Delete.Execute on an org that was never initialized by platform.Deploy.Execute, causing 'No API endpoint set' failures.
it.Pend marks the spec as pending at registration time — no it.Before or it.After hooks fire for it at all, so cleanup is never attempted.