Skip to content

fix#1

Merged
cliffordh merged 3 commits intocliffordh:mainfrom
melmathari:fix
Jan 8, 2026
Merged

fix#1
cliffordh merged 3 commits intocliffordh:mainfrom
melmathari:fix

Conversation

@melmathari
Copy link
Copy Markdown
Contributor

@melmathari melmathari commented Dec 31, 2025

Compilation errors. The issue was that two files were directly importing GoogleSignIn without conditional compilation.

Mohamed Mathari added 2 commits December 31, 2025 19:46
@cliffordh
Copy link
Copy Markdown
Owner

Hey @melmathari, thanks for the PR and for catching the GoogleSignIn conditional compilation issue, that's a real bug!

I ran the build locally and discovered that the CI failure is caused by the change in StreakBadgeView.swift due to ConfettiCannon. The library uses trigger: not counter:, so this change needs to be reverted.

Additionally, the changes in AppConfiguration.swift (disabling RevenueCat/TelemetryDeck) appear to be local test settings that slipped in - those should also be reverted.

If you can push a commit that:

  1. Preserves the #if canImport(GoogleSignIn) guards (those are beneficial!)
  2. Reverts the ConfettiCannon parameter back to trigger:
  3. Reverts the AppConfiguration flags back to true,

I'll merge it immediately. Thank you again for contributing!

@melmathari
Copy link
Copy Markdown
Contributor Author

I'll try to do that this week. Thank you for getting back

@melmathari
Copy link
Copy Markdown
Contributor Author

@cliffordh feel free to review

@cliffordh cliffordh merged commit 16632bf into cliffordh:main Jan 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants