Merged
Conversation
added 2 commits
December 31, 2025 19:46
Owner
|
Hey @melmathari, thanks for the PR and for catching the GoogleSignIn conditional compilation issue, that's a real bug! I ran the build locally and discovered that the CI failure is caused by the change in StreakBadgeView.swift due to ConfettiCannon. The library uses trigger: not counter:, so this change needs to be reverted. Additionally, the changes in AppConfiguration.swift (disabling RevenueCat/TelemetryDeck) appear to be local test settings that slipped in - those should also be reverted. If you can push a commit that:
I'll merge it immediately. Thank you again for contributing! |
Contributor
Author
|
I'll try to do that this week. Thank you for getting back |
Contributor
Author
|
@cliffordh feel free to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation errors. The issue was that two files were directly importing GoogleSignIn without conditional compilation.