Create a new PDF as a Buffer + Upgrade to Muhammara 3.0.0#237
Open
deltazero-cz wants to merge 3 commits intochunyenHuang:masterfrom
Open
Create a new PDF as a Buffer + Upgrade to Muhammara 3.0.0#237deltazero-cz wants to merge 3 commits intochunyenHuang:masterfrom
deltazero-cz wants to merge 3 commits intochunyenHuang:masterfrom
Conversation
Collaborator
|
hey there, im the maintainer of muhammara and started implementing recipe directly into muhammara, it would be awesome to get some feedback on this: julianhille/MuhammaraJS#253 |
Open
Owner
|
Thanks can you help with this PR too #234 I haven't worked for this repo for a while. I am thinking maybe I can add you guys to the admin to merge codes as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I often use PDFs as buffers instead of sync fs files. I've made some small updates in order to be able to create new PDF using buffers (both isBufferSrc and isNewPDF are true). Use as follows: