feat: add option to not quit form after submission#469
Open
jonas-grgt wants to merge 1 commit intocharmbracelet:mainfrom
Open
feat: add option to not quit form after submission#469jonas-grgt wants to merge 1 commit intocharmbracelet:mainfrom
jonas-grgt wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
jonas-grgt
force-pushed
the
feat/not-quitting-form
branch
2 times, most recently
from
ef38ce1 to
c94f4d1
Compare
Contributor
Author
|
This should close #446 |
jonas-grgt
force-pushed
the
feat/not-quitting-form
branch
2 times, most recently
from
8c463aa to
c5787a7
Compare
jonas-grgt
force-pushed
the
feat/not-quitting-form
branch
from
c5787a7 to
3364066
Compare
Contributor
Author
|
Maybe it would be better to expose this functionality through an explicit setter instead of directly exposing the field? As in: form.WithQuitAfterSubmit(false); // to not quit the form after submittingWDYT? |
jonas-grgt
force-pushed
the
feat/not-quitting-form
branch
from
bd036ba to
65796e2
Compare
Contributor
Author
|
Just rebased this PR to resolve conflicts and keep it up to date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the option to keep the form visible after submission. Afterwards the form could be reactivated using
f.Init().This is useful for when submitting something that might fail and needs some further editing.