Honor Enter/Shift+Enter setting consistently#168
Open
cfal wants to merge 1 commit into
Open
Conversation
Removes mobile-specific logic, so the "Send by Shift+Enter" setting now applies equally on mobile and desktop. Enter key behavior in the prompt composer now consistently follows the user preference regardless of device. Updates related tests and removes unused isMobile handling.
cfal
force-pushed
the
main
branch
2 times, most recently
from
a5de8e1 to
5015066
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes composer submit behavior so the existing
Send by Shift+Entersetting is the single source of truth for keyboard submission.Previously, the shared shortcut helper forced Enter to insert a newline on mobile, regardless of the user setting. That made the setting behave inconsistently across composer surfaces and viewport types.
Changes:
Validation:
bun run checkbun run testtimeout 90s bun run start --port 0