Fix Facebook cookie dialog detection and consent logic:#573
Open
opensource-belgium wants to merge 2 commits intocavi-au:masterfrom
Open
Fix Facebook cookie dialog detection and consent logic:#573opensource-belgium wants to merge 2 commits intocavi-au:masterfrom
opensource-belgium wants to merge 2 commits intocavi-au:masterfrom
Conversation
opensource-belgium
commented
Mar 28, 2026
opensource-belgium
commented
- Replace data-testid selector with div[role='dialog'] (data-testid no longer present in Facebook's DOM)
- Add Unicode apostrophe (U+2019) to French textFilter — Facebook uses typographic apostrophe in "l'utilisation" which breaks ASCII-based matching
- Fix inverted ifallowall logic (trueAction was clicking "essential only" instead of "accept all")
- Move HIDE_CMP after DO_CONSENT to prevent hiding dialog before clicking
- Scope button selectors to div[role='dialog'] to avoid matching unrelated buttons
- Add DE/ES/IT translations for broader language coverage
Fix Facebook cookie dialog detection and consent logic: - Replace data-testid selector with div[role='dialog'] (data-testid no longer present in Facebook's DOM) - Add Unicode apostrophe (U+2019) to French textFilter — Facebook uses typographic apostrophe in "l'utilisation" which breaks ASCII-based matching - Fix inverted ifallowall logic (trueAction was clicking "essential only" instead of "accept all") - Move HIDE_CMP after DO_CONSENT to prevent hiding dialog before clicking - Scope button selectors to div[role='dialog'] to avoid matching unrelated buttons - Add DE/ES/IT translations for broader language coverage
Update cookie policy selectors and actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.