fix: don't steal focus from user's active element when handling consents#560
Open
jhult wants to merge 1 commit intocavi-au:masterfrom
Open
fix: don't steal focus from user's active element when handling consents#560jhult wants to merge 1 commit intocavi-au:masterfrom
jhult wants to merge 1 commit intocavi-au:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #557
When handling consent popups, the extension was unconditionally blurring the currently focused element. This caused issues when users were typing in textboxes mid-page load, as keystrokes would be lost when the consent handler stole focus.
Now, the extension only blurs the active element if it's inside the consent popup that was just handled, preserving user focus in other elements.