Sanitize service names containing slashes#547
Merged
aparajon merged 1 commit intocashapp:masterfrom Mar 25, 2026
Merged
Conversation
Service names with slashes (e.g., "ki/ki") break URL routing in the UI because the slash becomes a path separator. Replace `/` with `-` in the service name before storing it in the database. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
frojasg
approved these changes
Mar 25, 2026
aparajon
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/with-in the service name inConfigureServiceActionbefore it is stored asregistry_namein the database.Test plan
ServiceShowActionTest.service name with slash should not produce extra path segments-- verifiesServiceShowAction.path("ki-ki", null)produces/services/ki-ki/with no extra path segments.ServiceShowActionTest.service with slash in name should be reachable after sanitization-- registers a service as "ki/ki", then confirms it is stored and retrievable as "ki-ki".🤖 Generated with Claude Code