crdupgradesafety: CalculateFlatSchemaDiff should ignore child items#1054
Open
joelanford wants to merge 1 commit intocarvel-dev:developfrom
Open
crdupgradesafety: CalculateFlatSchemaDiff should ignore child items#1054joelanford wants to merge 1 commit intocarvel-dev:developfrom
joelanford wants to merge 1 commit intocarvel-dev:developfrom
Conversation
Signed-off-by: Joe Lanford <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See operator-framework/operator-controller#1860
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
The
FlatSchemastruct contains a mapping of every field at all levels of the type hierarchy containing the schema of that field. In the case of fields that are structs, theCalculateFlatSchemaDifffunction ignores the child properties because the child properties have their own schemas defined elsewhere in the map. For this same reason,CalculateFlatSchemaDiffshould also ignore childItems.Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: