Save map builder options in options proto. Rename it to BuilderOptions.#1504
Save map builder options in options proto. Rename it to BuilderOptions.#1504ojura wants to merge 3 commits intocartographer-project:masterfrom
Conversation
|
I verified that the pbstream info tool correctly prints out the map builder options for .pbstreams produced with this version of Cartographer. For older pbstreams it just prints out an empty string for map builder options. |
| CHECK(ReadNextSerializedData(&all_trajectory_builder_options_)) | ||
| << "Serialized stream misses `AllTrajectoryBuilderOptions`."; | ||
| CHECK(all_trajectory_builder_options_.has_all_trajectory_builder_options()) | ||
| CHECK(ReadNextSerializedData(&builder_options_)) |
There was a problem hiding this comment.
Does this break compatibility?
There was a problem hiding this comment.
It is the same proto, just renamed to builder options (instead of all trajectory builder options), since it now contains the map builder options as well.
Also I mentioned above that I tested it with bags built by upstream Cartographer, it works okay (prints a blank line for nonexisting map builder options).
|
@ojura this was reviewed and approved a long time ago but somehow not merged. It is now outdated and has many conflicts. Do you still have time to resolve the conflict? |
6 participants
RFC=cartographer-project/rfcs#38