chore: remove dead showRxChartNo preference and related code#1971
chore: remove dead showRxChartNo preference and related code#1971
Conversation
The showRxChartNo preference had no admin UI to toggle it and shipped defaulted to false. Remove the preference from carlos.properties (both main and devcontainer copies) along with the JSP scriptlet that read it, the ptChartNo variable it populated, the hidden patientChartNo input that submitted to FrmCustomedPDFServlet, and the display block in Preview2.jsp that rendered the chart number. Behavior is preserved: FrmCustomedPDFServlet still reads patientChartNo from the request, defaults null to empty, and skips rendering when empty — equivalent to the prior showRxChartNo=false default.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 58 minutes and 3 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Failed to generate code suggestions for PR |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Browser as Client Browser
participant JSP as Preview2.jsp (Server-side)
participant Config as carlos.properties
participant Servlet as FrmCustomedPDFServlet
Note over Browser,Servlet: Rx Preview and PDF Generation Flow
Browser->>JSP: GET /rx/Preview2.jsp
Note over JSP: CHANGED: showRxChartNo preference logic removed
JSP->>JSP: Build hidden form fields
Note right of JSP: CHANGED: 'patientChartNo' hidden input removed
JSP-->>Browser: Render Preview HTML
Note over Browser: User clicks "Print" or "Save"
Browser->>Servlet: POST (patientCityPostal, patientHIN, etc.)
Note over Servlet: CHANGED: Request no longer contains 'patientChartNo'
Servlet->>Servlet: getParameter("patientChartNo")
alt patientChartNo is null or empty
Servlet->>Servlet: Skip rendering Chart Number in PDF
end
Servlet-->>Browser: Return Generated PDF Document
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the showRxChartNo configuration and its associated logic from the CARLOS EMR system. The changes involve deleting the property from configuration files and removing the code responsible for retrieving and displaying the patient's chart number on the prescription preview page. I have no feedback to provide.
There was a problem hiding this comment.
Pull request overview
Removes a dead showRxChartNo configuration preference and the associated prescription preview/JSP logic that previously (conditionally) displayed and submitted a patient chart number.
Changes:
- Removed
showRxChartNofromcarlos.properties(main + devcontainer copies). - Removed the
showRxChartNocheck,ptChartNovariable, and thepatientChartNohidden form field fromPreview2.jsp. - Removed the chart number rendering block from the prescription preview UI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/webapp/WEB-INF/jsp/rx/Preview2.jsp |
Deletes dead preference-driven chart number derivation, submission, and display. |
src/main/resources/carlos.properties |
Removes unused showRxChartNo property entry. |
.devcontainer/development/config/shared/volumes/carlos.properties |
Removes unused showRxChartNo property entry from devcontainer config. |
|
The showRxChartNo preference had no admin UI to toggle it and shipped
defaulted to false. Remove the preference from carlos.properties (both
main and devcontainer copies) along with the JSP scriptlet that read it,
the ptChartNo variable it populated, the hidden patientChartNo input
that submitted to FrmCustomedPDFServlet, and the display block in
Preview2.jsp that rendered the chart number.
Behavior is preserved: FrmCustomedPDFServlet still reads patientChartNo
from the request, defaults null to empty, and skips rendering when
empty — equivalent to the prior showRxChartNo=false default.
Summary by cubic
Removed dead
showRxChartNopreference and the related chart number UI in Rx preview. Behavior remains the same: chart number is omitted unless provided toFrmCustomedPDFServlet.showRxChartNofromsrc/main/resources/carlos.propertiesand.devcontainer/development/config/shared/volumes/carlos.properties.ptChartNo, hiddenpatientChartNofield, and the chart number display block insrc/main/webapp/WEB-INF/jsp/rx/Preview2.jsp.Written for commit efba6b6. Summary will update on new commits.