(docs): Add Google Analytics to Multipass documentation#4219
Merged
sharder996 merged 1 commit intomainfrom Jul 23, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4219 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 259 259
Lines 15684 15684
=======================================
Hits 14008 14008
Misses 1676 1676 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geoffreynyaga
changed the title
SecondSkoll
approved these changes
Jul 11, 2025
| {% endif %} | ||
| </div> | ||
| <div class="right-details"><a href="" class="js-revoke-cookie-manager muted-link">Manage your tracker settings</a></div> | ||
| </div> No newline at end of file |
There was a problem hiding this comment.
Suggested change
| </div> | |
| </div> | |
Fixes linting check.
xmkg
approved these changes
Jul 11, 2025
Member
xmkg
left a comment
xmkg
left a comment
There was a problem hiding this comment.
LGTM, the cookie prompt, and the footer work as expected. As for the analytics, I don't have visibility over that, so verifying that will be up to you @geoffreynyaga :)
geoffreynyaga
pushed a commit
that referenced
this pull request
Dec 3, 2025
This PR adds analytics to Multipass documentation: Using https://github.com/canonical/RTD-cookie-banner-integration, this PR adds the following: - HTML templates for footer and header to support Google Analytics and cookie consent banner. - JS bundle for GA functionality and cookie consent. - CSS configuration to style consent banner. - Configuration to support required template and static files. Expected results: <img width="1123" alt="Screenshot 2025-07-09 at 15 39 52" src="https://github.com/user-attachments/assets/5a7c03fe-80f2-47c7-9cc3-58ade9473f7b" /> JIRA MULTI-2083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds analytics to Multipass documentation:
Using https://github.com/canonical/RTD-cookie-banner-integration, this PR adds the following:
Expected results:
JIRA
MULTI-2083