fix: override image description label to remove emojis#552
Closed
leiicamundi wants to merge 1 commit intomainfrom
Closed
fix: override image description label to remove emojis#552leiicamundi wants to merge 1 commit intomainfrom
leiicamundi wants to merge 1 commit intomainfrom
Conversation
Explicitly set org.opencontainers.image.description in all Dockerfiles to prevent the emoji-laden GitHub repo description (injected by docker/metadata-action) from breaking enterprise registries like JFrog.
There was a problem hiding this comment.
Pull request overview
This PR hard-codes an OCI image description label in the Keycloak image Dockerfiles so the final org.opencontainers.image.description does not inherit the GitHub repository description (and its emojis), which can break stricter enterprise registries.
Changes:
- Add an explicit
org.opencontainers.image.descriptionlabel to all Keycloak 23–26 Dockerfiles (Bitnami and Quay variants). - Remove the now-misleading “generated at buildtime” comment entry for
org.opencontainers.image.descriptionin each Dockerfile.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| keycloak-26/Dockerfile.quay | Adds explicit OCI description label for Keycloak 26 Quay image. |
| keycloak-26/Dockerfile | Adds explicit OCI description label for Keycloak 26 Bitnami image. |
| keycloak-25/Dockerfile.quay | Adds explicit OCI description label for Keycloak 25 Quay image. |
| keycloak-25/Dockerfile | Adds explicit OCI description label for Keycloak 25 Bitnami image. |
| keycloak-24/Dockerfile.quay | Adds explicit OCI description label for Keycloak 24 Quay image. |
| keycloak-24/Dockerfile | Adds explicit OCI description label for Keycloak 24 Bitnami image. |
| keycloak-23/Dockerfile.quay | Adds explicit OCI description label for Keycloak 23 Quay image. |
| keycloak-23/Dockerfile | Adds explicit OCI description label for Keycloak 23 Bitnami image. |
marcel-dias
approved these changes
Apr 14, 2026
Contributor
Author
|
closed in favor of https://github.com/camunda/infraex-terraform/pull/350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly set org.opencontainers.image.description in all Dockerfiles to prevent the emoji-laden GitHub repo description (injected by docker/metadata-action) from breaking enterprise registries like JFrog.