Added checkRoute function to check if a route is defined into router#2
Open
javiertoledo wants to merge 1 commit into
Open
Added checkRoute function to check if a route is defined into router#2javiertoledo wants to merge 1 commit into
javiertoledo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin is awesome, congratulations for your work!
I have added a checkRoute function to be able to know which routes are defined in the router. I've used it to automatically differentiate between inner and external URLs in order to watch any link click in the page and route it accordingly. Also edited the README file to show this change and my editor removed some whitespace.
I don't know if it exist a better solution for this, but this is my code to listen for user clicks by now:
Maybe something like this could be activated by default or with an option inside of
bindStateEventsfunction so page will start responding to any internal URLs with the router automatically, what do you think?Best regards from Canary Islands! :-)