feat: populate ToolCallingRecord.images when tool returns ToolResult#3981
Open
KIA-Er wants to merge 2 commits intocamel-ai:masterfrom
Open
feat: populate ToolCallingRecord.images when tool returns ToolResult#3981KIA-Er wants to merge 2 commits intocamel-ai:masterfrom
KIA-Er wants to merge 2 commits intocamel-ai:masterfrom
Conversation
Address camel-ai#3964 When a tool returns ToolResult with images, populate the ToolCallingRecord.images field with the image list. This ensures consistency across sync, async, and streaming execution paths. Changes: - Extract images from ToolResult in _record_tool_calling - Populate ToolCallingRecord.images in all execution paths - Maintain consistency with existing ToolResult handling Note: Only ToolResult type is supported for images field population, keeping the API boundary clear as suggested by maintainers. Question: I noticed that in sync path (_record_tool_calling), when a tool returns ToolResult with images, the images are injected into memory via visual_msg (lines 4214-4269). However, in streaming paths, the images are only populated in ToolCallingRecord.images but not injected into memory. Is this intentional, or should streaming paths also inject images into memory for consistency?
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #3964
When a tool returns ToolResult with images, populate the ToolCallingRecord.images field with the image list. This ensures consistency across sync, async, and streaming execution paths.
Changes:
Note: Only ToolResult type is supported for images field population, keeping the API boundary clear as suggested by maintainers.
Question: I noticed that in sync path (_record_tool_calling), when a tool returns ToolResult with images, the images are injected into memory via visual_msg (lines 4214-4269). However, in streaming paths, the images are only populated in ToolCallingRecord.images but not injected into memory. Is this intentional, or should streaming paths also inject images into memory for consistency?
Related Issue
Closes #3964
Description
What is the purpose of this pull request?
Checklist
pyproject.tomland runuv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!