Skip to content

Support for 'default' value in segment background#164

Open
gagarski wants to merge 4 commits intocaiogondim:masterfrom
gagarski:context_bright_theme
Open

Support for 'default' value in segment background#164
gagarski wants to merge 4 commits intocaiogondim:masterfrom
gagarski:context_bright_theme

Conversation

@gagarski
Copy link
Copy Markdown

@gagarski gagarski commented Sep 29, 2016

When a terminal theme is bright (with black font color), the context segment content is invisible (because it is black on black). Here I set the default foreground color to white for this segment.

@vadviktor
Copy link
Copy Markdown
Collaborator

I have checked this fix in KDE5 Konsole and @gagarski has a point, on white background themes the context segment is busted, all black. The change does not seem to affect further use on other colourschemes, all looks good.

@dawikur @caiogondim any objections?

@dawikur
Copy link
Copy Markdown
Collaborator

dawikur commented Mar 22, 2017

It makes a point, but maybe the better way would be not to set color neither on BG nor FG, instead of forcing it on both?

@vadviktor
Copy link
Copy Markdown
Collaborator

Well, the other contexts also have their "default" colours, it doesn't feel like we are forcing it but setting a sensible default. Am I not right?
Also, these are just defaults and can be overridden.
As I see it with the white value, a newbie user comes with his white BG terminal and will NOT see the theme "buggy". :)

@gagarski
Copy link
Copy Markdown
Author

@dawikur As far as I understand we cannot draw an arrow () with transparent FG and blue (default for path segment) BG using terminal escape sequences. That's why black BG is forced.

@gagarski
Copy link
Copy Markdown
Author

@dawikur

As far as I understand we cannot draw an arrow () with transparent FG and blue (default for path segment) BG using terminal escape sequences.

Looks like we can and I now am playing around with this, so I'll push update when I test it.

@gagarski gagarski force-pushed the context_bright_theme branch from f02773e to 30a7f51 Compare March 22, 2017 17:13
@gagarski gagarski changed the title Make context segment visible on bright terminal theme Support for 'default' value in segment background Mar 22, 2017
@gagarski
Copy link
Copy Markdown
Author

So, now we can set 'default' as background for any segment. Did it by default for custom and context segments. Rebased everything on top of master branch.

@gagarski gagarski force-pushed the context_bright_theme branch from f1ab41f to 429c988 Compare December 14, 2017 16:29
@gagarski
Copy link
Copy Markdown
Author

Rebased everything on top of master

@gagarski
Copy link
Copy Markdown
Author

@dawikur @caiogondim Is it ok or should I change/update something to get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants