Skip to content

docs: persistence.md (consistent name for postgresql)#6429

Merged
c-warren merged 3 commits intocadence-workflow:masterfrom
seanorama:patch-1
May 4, 2026
Merged

docs: persistence.md (consistent name for postgresql)#6429
c-warren merged 3 commits intocadence-workflow:masterfrom
seanorama:patch-1

Conversation

@seanorama
Copy link
Copy Markdown
Contributor

What changed?

Minor docs fixes.

Made consistent naming, as it was postgres in some places and postgresql in others. The full name helps with finding in searches.

And fixing cases from PostgresQL to PostgreSQL.

Why?

Fix docs.

How did you test it?

Docs only.

Potential risks

Nothing, except maybe invalid markdown.

Release notes

None.

Documentation Changes

None in cadence-docs.

Minor docs fixes.

Made consistent naming, as it was postgres in some places and postgresql in others. The full name helps with finding in searches.

And fixing cases from PostgresQL to PostgreSQL.
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment thread docs/persistence.md Outdated
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 1, 2026

Gitar is not allowed to push to this forked PR.

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 1, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Updates documentation for consistent PostgreSQL naming and corrects external repository URLs. Adds automated test coverage for the reconciliation fetcher.

✅ 1 resolved
Bug: Link changed to wrong GitHub org URL

📄 docs/persistence.md:225
Line 225 changes the NoSQL persistence API link from github.com/cadence-workflow/cadence/blob/master/... to github.com/uber/cadence/blob/master/.... The repo was moved to the cadence-workflow org, so this introduces an unnecessary redirect (or could break if the uber redirect is ever removed). The other links in this file already use cadence-workflow.

Rules ❌ No requirements met

Repository Rules

PR Description Quality Standards: The PR description lacks required technical detail in '[Why?]' and '[How did you test it?]' sections, and includes irrelevant commit information not reflected in the actual diff.

2 rules not applicable. Show all rules by commenting gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@c-warren c-warren merged commit 93d7a40 into cadence-workflow:master May 4, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants