Skip to content

caddyauth: add candidate placeholders for rejected identities#7698

Open
steadytao wants to merge 1 commit into
masterfrom
fix-auth-candidate-placeholders
Open

caddyauth: add candidate placeholders for rejected identities#7698
steadytao wants to merge 1 commit into
masterfrom
fix-auth-candidate-placeholders

Conversation

@steadytao
Copy link
Copy Markdown
Member

Reimplementing the fix for 7684 while using the correct placeholder.

  • Preserve http.auth.user.* for successfully authenticated principals only
  • Add http.auth.candidate.* when an authentication provider returns user information but authentication is rejected
  • Avoid exposing candidate placeholders for successful authentication or empty rejected users
  • Add caddyauth tests covering candidate placeholders, user placeholders and rejected candidate leakage

Fixes #7684.
Closes #7687.

Assistance Disclosure

No AI was used.

@mholt mholt added this to the v2.11.4 milestone May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify caddyauth user placeholder semantics after #7685 Set http.auth.user variables even on unsuccessful authentication

2 participants