Skip to content

fix(frontend): prevent memory settings layout overflow#2420

Merged
WillemJiang merged 2 commits intobytedance:mainfrom
LittleChenLiya:investigate/issue-2418-memory-layout
Apr 24, 2026
Merged

fix(frontend): prevent memory settings layout overflow#2420
WillemJiang merged 2 commits intobytedance:mainfrom
LittleChenLiya:investigate/issue-2418-memory-layout

Conversation

@LittleChenLiya
Copy link
Copy Markdown
Contributor

@LittleChenLiya LittleChenLiya commented Apr 22, 2026

Summary

  • Allow the settings dialog content column to shrink with minmax(0, 1fr).
  • Add min-w-0 to the scroll/content containers and Memory toolbar groups so long button groups wrap inside the panel instead of expanding past the dialog.
  • Force Memory summary and fact text to wrap within the panel, including long English text or unbroken content.

Root Cause

The settings dialog used a 220px 1fr grid. Because grid items default to min-width: auto, the Memory page toolbar and markdown content could force the right content column wider than the dialog. The toolbar contains non-shrinking buttons, and long summary/fact text did not have an aggressive wrap rule, so controls or content could overflow outside the settings panel in constrained widths.

Fixes #2418.

Verification

  • pnpm.cmd format
  • pnpm.cmd lint
  • pnpm.cmd typecheck
  • BETTER_AUTH_SECRET=local-dev-secret pnpm.cmd build

The production build completed successfully. It emitted local Better Auth secret/base URL warnings and Nextra git timestamp warnings, but no build errors.

@LittleChenLiya LittleChenLiya force-pushed the investigate/issue-2418-memory-layout branch from 23a996d to fa9acb9 Compare April 22, 2026 06:59
@WillemJiang WillemJiang marked this pull request as ready for review April 24, 2026 08:57
@WillemJiang WillemJiang requested a review from Copilot April 24, 2026 08:57
@WillemJiang WillemJiang changed the title fix: prevent memory settings layout overflow fix(frontend): prevent memory settings layout overflow Apr 24, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Settings dialog layout overflow on the Memory settings page by allowing the right-hand content column and its children to shrink and wrap correctly in constrained widths.

Changes:

  • Updated the Settings dialog grid to use minmax(0, 1fr) so the content column can shrink without forcing overflow.
  • Added min-w-0 to scroll/content containers and Memory toolbar wrappers to prevent flex/grid min-content sizing from expanding the dialog.
  • Forced long Memory summary/fact text (including unbroken strings) to wrap within the panel using overflow-wrap:anywhere.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
frontend/src/components/workspace/settings/settings-dialog.tsx Makes the right grid column shrinkable and prevents the ScrollArea/content container from forcing dialog overflow.
frontend/src/components/workspace/settings/memory-settings-page.tsx Adds shrink/wrap constraints to toolbar and Memory markdown/text blocks so long content doesn’t expand past the panel.

@WillemJiang WillemJiang merged commit c2332bb into bytedance:main Apr 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

记忆界面展示有问题

3 participants