fix(frontend): prevent memory settings layout overflow#2420
Merged
WillemJiang merged 2 commits intobytedance:mainfrom Apr 24, 2026
Merged
Conversation
Closed
23a996d to
fa9acb9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Settings dialog layout overflow on the Memory settings page by allowing the right-hand content column and its children to shrink and wrap correctly in constrained widths.
Changes:
- Updated the Settings dialog grid to use
minmax(0, 1fr)so the content column can shrink without forcing overflow. - Added
min-w-0to scroll/content containers and Memory toolbar wrappers to prevent flex/grid min-content sizing from expanding the dialog. - Forced long Memory summary/fact text (including unbroken strings) to wrap within the panel using
overflow-wrap:anywhere.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/components/workspace/settings/settings-dialog.tsx | Makes the right grid column shrinkable and prevents the ScrollArea/content container from forcing dialog overflow. |
| frontend/src/components/workspace/settings/memory-settings-page.tsx | Adds shrink/wrap constraints to toolbar and Memory markdown/text blocks so long content doesn’t expand past the panel. |
WillemJiang
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minmax(0, 1fr).min-w-0to the scroll/content containers and Memory toolbar groups so long button groups wrap inside the panel instead of expanding past the dialog.Root Cause
The settings dialog used a
220px 1frgrid. Because grid items default tomin-width: auto, the Memory page toolbar and markdown content could force the right content column wider than the dialog. The toolbar contains non-shrinking buttons, and long summary/fact text did not have an aggressive wrap rule, so controls or content could overflow outside the settings panel in constrained widths.Fixes #2418.
Verification
pnpm.cmd formatpnpm.cmd lintpnpm.cmd typecheckBETTER_AUTH_SECRET=local-dev-secret pnpm.cmd buildThe production build completed successfully. It emitted local Better Auth secret/base URL warnings and Nextra git timestamp warnings, but no build errors.