Skip to content

Sourcery Starbot ⭐ refactored bwlambert/planetscraper #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SourceryAI wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sourcery Starbot ⭐ refactored bwlambert/planetscraper #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions create_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def getListOfFiles(dirName):
# create a list of file and sub directories
# names in the given directory
listOfFile = os.listdir(dirName)
allFiles = list()
allFiles = []
Copy link
Copy Markdown
Author

@SourceryAI SourceryAI Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function getListOfFiles refactored with the following changes:

# Iterate over all the entries
for entry in listOfFile:
# Create full path
Expand All @@ -112,7 +112,7 @@ def getListOfFiles(dirName):
allFiles = allFiles + getListOfFiles(fullPath)
else:
allFiles.append(fullPath)

return allFiles


Expand All @@ -121,17 +121,16 @@ def getListOfMetadataFiles(dirName):
# create a list of file and sub directories
# names in the given directory
listOfFile = os.listdir(dirName)
allFiles = list()
allFiles = []
# Iterate over all the entries
for entry in listOfFile:
# Create full path
fullPath = os.path.join(dirName, entry)
# If entry is a directory then get the list of files in this directory
# If entry is a directory then get the list of files in this directory
if os.path.isdir(fullPath):
allFiles = allFiles + getListOfFiles(fullPath)
else:
if regex.match(fullPath):
allFiles.append(fullPath)
elif regex.match(fullPath):
allFiles.append(fullPath)
Comment on lines -124 to +133
Copy link
Copy Markdown
Author

@SourceryAI SourceryAI Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function getListOfMetadataFiles refactored with the following changes:


#filtered = [i for i in full if not regex.match(i)]
#return filtered
Expand Down
Loading