Replaced coreutils-full with toybox and coreutils for improved security#136
Open
rishi-prajapati wants to merge 2 commits intobuildsafedev:mainfrom
Open
Replaced coreutils-full with toybox and coreutils for improved security#136rishi-prajapati wants to merge 2 commits intobuildsafedev:mainfrom
rishi-prajapati wants to merge 2 commits intobuildsafedev:mainfrom
Conversation
Contributor
rakshitgondwal
left a comment
rakshitgondwal
left a comment
There was a problem hiding this comment.
Thank you for the PR @rishi-prajapati, can you please sign you commit for the faling DCO check? You'll also need to add youself to the CONTRIBUTORS.md file.
Signed-off-by: rishi-prajapati <[email protected]>
rishi-prajapati
force-pushed
the
feature
branch
from
d2ce47d to
b540936
Compare
Signed-off-by: rishi-prajapati <[email protected]>
Author
|
Hi @rakshitgondwal I have signed the commit and also updated CONTRIBUTORS.md file. |
rakshitgondwal
approved these changes
Jan 6, 2025
Contributor
rakshitgondwal
left a comment
rakshitgondwal
left a comment
There was a problem hiding this comment.
lgtm, @dr-housemd do you wanna have a look?
Author
|
Hi @rakshitgondwal, Any updates on this issue? |
Contributor
|
Hey @rishi-prajapati, The changes are good but we have a blocker for this to be merged: #122 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123
This update replaces the coreutils-full package with toybox and coreutils to enhance security. The toybox package is a lightweight alternative that includes essential utilities, while coreutils remains to provide a more comprehensive set of core utilities. These changes aim to improve the security and efficiency of the system by reducing unnecessary dependencies and simplifying the overall package structure.