Skip to content

Added delete bot command. Minor bug fixes.#14

Open
SheffieldKevin wants to merge 11 commits intobuildasaurs:masterfrom
SheffieldKevin:master
Open

Added delete bot command. Minor bug fixes.#14
SheffieldKevin wants to merge 11 commits intobuildasaurs:masterfrom
SheffieldKevin:master

Conversation

@SheffieldKevin
Copy link
Copy Markdown

No description provided.

call_endpoint("post", endpoint, body)
end

def delete_endpoint(endpoint, body)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'll ever need the body here, feel free to remove it and pass in nil.

@czechboy0
Copy link
Copy Markdown
Member

Thanks for the addition! Why the change to --host?

@czechboy0
Copy link
Copy Markdown
Member

Ah I see, you're right it's supposed to be --host, nice catch!

@czechboy0
Copy link
Copy Markdown
Member

Please merge from master so that CI passes and I'll merge this. 👍

@SheffieldKevin
Copy link
Copy Markdown
Author

I have no trouble installing the ruby gem and I'm not sure what the problem is.

@czechboy0
Copy link
Copy Markdown
Member

I was testing on 3 Ruby versions and 2.0.0 was failing, so I removed it (I don't want to support it anyway). All you have to do is merge from master and that should make the CI happy :)

@SheffieldKevin
Copy link
Copy Markdown
Author

Excuse my ignorance. But how do I merge from master?

@SheffieldKevin
Copy link
Copy Markdown
Author

I see what I need to do. Apologies I thought I was up to date with the repository.

@czechboy0
Copy link
Copy Markdown
Member

Damn, seems like some dependency is failing to install
https://travis-ci.org/czechboy0/xcskarel/jobs/115682593
Do you maybe want to look into replacing/removing it? I haven't done an audit of dependencies in a long time.

@SheffieldKevin
Copy link
Copy Markdown
Author

I hadn't updated my ruby from 2.2.1. After updating to 2.2.2 I could no longer do a rake install. It looks like rspec needs to be updated.

@SheffieldKevin
Copy link
Copy Markdown
Author

I seem to have reached the limit of my almost non existent knowledge of how ruby gems work.

@SheffieldKevin
Copy link
Copy Markdown
Author

I think the problem is that travis can't run the tests because it can't install the gem xcskarel (v 0.16.2). I can't push the gem to rubygems.org because I don't have permission to do so.

@czechboy0
Copy link
Copy Markdown
Member

Ok, I finally got it working, there were Travis issues. Please merge from master, should make this green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants