Add cache refresh queries before TTL expiry#64
Open
AgbediaSamuel wants to merge 1 commit intobrutella:masterfrom
Open
Add cache refresh queries before TTL expiry#64AgbediaSamuel wants to merge 1 commit intobrutella:masterfrom
AgbediaSamuel wants to merge 1 commit intobrutella:masterfrom
Conversation
Re-sends PTR queries at 80% of the earliest cached record's TTL, preventing services from silently disappearing while still online. Fixes brutella#63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements RFC 6762 Section 5.2 cache refresh queries in the browser.
Currently,
LookupTypesends a PTR query once at startup and then passively listens. When a cached record's TTL expires, the service silently disappears from the browse list even if it's still online.This PR adds a refresh timer that re-sends the PTR query at 80% of the earliest cached record's TTL. If the service responds, the cache refreshes and the timer resets. If it doesn't respond, the TTL expires naturally and
rmvfires as before.Changes:
cache.go: Track earliest expiration across cached services, recalculate on removalbrowse.go: Add refresh timer in the select loop, re-query before TTL expirycache_test.go: Tests for expiration tracking, recalculation on removal, empty cacheFixes #63
Thank you for maintaining this project @brutella