Missing imports eglot

[samhedin]

For #169
Now supports both eglot and lsp. I'm not a huge fan of how I collect the missing imports from eglot. It works by inspecting errors that eglot is about to send to flymake, which makes it a bit hacky. In the lsp-mode version, a call to the function lsp-diagnostics just returns everything that's needed, but I could not find an equivalent function in eglot, though obviously it must be there somewhere.

Werks on my machine, but I need to try it a bit more and have another look at the code.

[brotzeit]

We still have the problem that we call lsp-mode/flymake code that we didn't require.

[samhedin]

Good catch, in my mind lsp-mode would return nil when undefined for some reason, but this is clearly not how most languages work, and when I tried it out I must have had lsp-mode loaded by accident. The flymake one is worse though. I want to remove the dependency on it altogether, but the eglot source code is doing so many things I'm unfamiliar with that I've been unable to get it to work with it at all. I might contact the author if I can't come up with anything.

[brotzeit]

Maybe we can add files for eglot and lsp-mode and require these files somewhere.

[samhedin]

As it is now, LSP and eglot should not be required if they're not loaded thanks to (ignore-error lsp-mode). Is there another reason to split them up?

[brotzeit]

You can do something like (if (featurep 'lsp-mode) (print "foo"))

[brotzeit]

You can funcall the lsp function here.

[samhedin]

Just an update, I contacted the eglot maintainers and they'd rather I do something else than the current solution, so I will look into that when I get time, but school is taking up all my focus at the moment.