Fix previous commit incomplete trading class matching filter logic#616
Merged
brndnmtthws merged 1 commit intobrndnmtthws:mainfrom Nov 7, 2025
Merged
Conversation
brndnmtthws
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My apologies but my last PR #614 introduced a bug (I found when doing further testing, e.g. VIX hedge calling). Another example is the IBKR
Contract::StockRKLBhas a tradingClassSCM(not sure why, the IBKR TWS shows RKLB but the API returns SCM).This fixes my last PR #614. I've tested it with VIX, IWM, RKLB, and more. There may be other edge cases out there but I think this covers most.