fix: correct weight info column placement in positions summary table#603
Merged
brndnmtthws merged 1 commit intomainfrom Aug 13, 2025
Merged
fix: correct weight info column placement in positions summary table#603brndnmtthws merged 1 commit intomainfrom
brndnmtthws merged 1 commit intomainfrom
Conversation
Owner
brndnmtthws
commented
Aug 12, 2025
brndnmtthws
commented
- Split format_weight_info to return weight and diff as separate strings
- Place weight info in "Target value" column instead of "Short calls"
- Place diff info in "Net target shares" column
- Remove unused color return value from format_weight_info
- Split format_weight_info to return weight and diff as separate strings - Place weight info in "Target value" column instead of "Short calls" - Place diff info in "Net target shares" column - Remove unused color return value from format_weight_info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.