fix(terraform): fix broken --skip-path command line option#7543
Open
brendanator wants to merge 1 commit into
Open
fix(terraform): fix broken --skip-path command line option#7543brendanator wants to merge 1 commit into
--skip-path command line option#7543brendanator wants to merge 1 commit into
Conversation
…ridgecrewio#7290) `'|'.join(f"({excluded_paths})")` interpolates the *list* into the f-string and then iterates the resulting string character-by-character, so the compiled regex is garbled regardless of the patterns passed in. With a single short pattern the garbled regex happened to compile and matched paths by individual character; with multiple patterns the join produces sequences (e.g. `*` after empty alternation) that `re.compile` rejects with "nothing to repeat". Change the call to iterate `excluded_paths` so each pattern becomes its own group, which is what the surrounding code expects. Add a regression test that fails before this change with `len(modules) == 0` (every path matched the garbled regex) and passes after.
eb56664 to
82fe1d5
Compare
--skip-path command line option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Fixes #7290 where the
excluded_pathsregex was always garbled, regardless of which patterns were passed via--skip-pathHere's what the code before and after does:
The fix iterates
excluded_pathsso each pattern becomes its own group, which is what the surrounding code already expects.Checklist