Allow non-String user values in work-unit data#11
Open
jdanbrown wants to merge 1 commit intoboundary:masterfrom
Open
Allow non-String user values in work-unit data#11jdanbrown wants to merge 1 commit intoboundary:masterfrom
jdanbrown wants to merge 1 commit intoboundary:masterfrom
Conversation
Contributor
Author
|
I agree that this change gives users more opportunity to use zk as a database instead of a coordination system, and I think that they shouldn't do that. ;) |
Contributor
|
So even more a reason to not even open up this possibility! If you leave your backdoor open in the hopes nobody will break in, then, believe me, they will eventually break in.:-) Again: UPDATE: Have you evaluated the effect of those ClassCastException failures on Ordasity through tests? It would be cool to commit a unit test to do so. The comparison of 'junk' with node id bears false while throwing a runtime exception may potentially have unpredictable results, doesn't it? See, I am assuming I can be totally wrong. :) UPDATE 2: Just out of curiosity, what kind of confusing behaviors? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small generalization to allow clients to stuff their own metadata into work-unit znodes:
Json.parse[Map[String, String]](workUnitData)->Json.parse[Map[String, Any]](workUnitData).