fix for removing botname from received text#17
Open
eldiaboloz wants to merge 1 commit intobotman:masterfrom
Open
fix for removing botname from received text#17eldiaboloz wants to merge 1 commit intobotman:masterfrom
eldiaboloz wants to merge 1 commit intobotman:masterfrom
Conversation
channelData->text holds the raw message and is escaped correclty text is already filtered, but still contains @botName so can not be used
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
============================================
+ Coverage 55.24% 55.47% +0.23%
- Complexity 42 43 +1
============================================
Files 4 4
Lines 143 146 +3
============================================
+ Hits 79 81 +2
- Misses 64 65 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Bot Framework SDK v4 and skype groupchat at least
"channelData->text" holds the raw message and is escaped correclty
"text" is already filtered, but still contains @ botname
so can not be used
Probably will fix #13 and #10