make pyo3 optional, support async dns validation, fix #31#32
Open
jb-alvarado wants to merge 3 commits into
Open
make pyo3 optional, support async dns validation, fix #31#32jb-alvarado wants to merge 3 commits into
jb-alvarado wants to merge 3 commits into
Conversation
…n, migrate trust-dns-resolver to new hickory-resolver
jb-alvarado
changed the title
Author
|
Hello @bnkc, any opinions on that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes pyo3 optional, but activate it as default. The normal behavior is not affected, but when we use this create in a rust project we can disable pyo3 with
default-features = false, because it is really not needed, also not polars.I also add a blocking feature and made default. If it is disabled async dns validation is supported.