Compatibility with newer JAX and numpy versions#45
Open
Jayshil wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bmorris3,
The current version of
kelpwill not work with newer JAX versions since there is a new way to enable 64-bit precision. Similarly, it will also not work with numpy 2. The main issue with numpy is thatnp.castwas removed in numpy 2. The error message suggests usingnp.asarrayinstead. I addressed both of these issues in this PR.I have tried this version on my computer, and my version is working well with numpy v2.1.3 and JAX v0.8.1. Please let me know if you have any questions or comments on this.
Cheers,
Jayshil