Feat/default notification channels#3656
Open
the-last-php-bender wants to merge 2 commits into
Open
Conversation
- Add isDefault field to notification model and types - Add endpoints: GET /notifications/defaults, PATCH /notifications/:id/default, POST /notifications/:id/apply-to-all - Add bulk add/remove notifications to monitors (PATCH /monitors/notifications) - Add UI for marking notifications as default - Add bulk notification actions in Uptime and Infrastructure monitor pages - Add Apply to All button in notification creation form - Auto-attach default notifications to new monitors - Update OpenAPI spec with new endpoints - Fix duplicate imports and JSON syntax in en.json
The createNotificationBodyValidation schema was stripping out the isDefault field when updating notifications, preventing the Default Channel feature from working properly. Changes: - Add isDefault: z.boolean().optional() to all 10 notification type schemas (email, webhook, slack, discord, pager_duty, matrix, teams, telegram, pushover, twilio) - Fix TypeScript type errors in frontend components - Fix import name in Infrastructure/Monitors page This enables users to toggle 'Default channel' on notifications and have them auto-attached to new monitors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Briefly describe the changes you made and their purpose.
This PR implements the ability to bulk-assign Notification Channels to Alerts as requested in issue #3601. The implementation includes:
Backend changes:
Frontend changes:
Write your issue number after "Fixes "
Fixes #3601
Please ensure all items are checked off before requesting a review. "Checked off" means you need to add an "x" character between brackets so they turn into checkmarks.
<div>Add</div>, use):npm run formatin server and client directories, which automatically formats your code.