Open
Conversation
pmackinlay
added a commit
to mamedev/mame
that referenced
this pull request
Nov 20, 2024
* pending upstream merge of bkaradzic/GENie#572
cuavas
pushed a commit
to mamedev/mame
that referenced
this pull request
Nov 26, 2024
…#13000) * Updated to GENie 1181. * Applied local fix for GENie resource include directory bug, sent upstream as bkaradzic/GENie#572. * Set MSVC flags to use conformant preprocessor, standards conformance mode, and assume UTF-8 encoding.
pmackinlay
added a commit
to pmackinlay/mame
that referenced
this pull request
Apr 8, 2026
* local fix for GENie resource include directory bug, sent upstream as bkaradzic/GENie#572 * local fix to disable broken command line escaping * local fix to use MPARAM instead of hard-coded -m64
Owner
|
Remove scripts.c from PR. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Visual Studio .vcxproj generator so the <ResourceCompile> item definition uses resource-specific include directories (resincludedirs) rather than the project’s general C/C++ include directories.
Changes:
- Add a VS generator helper to emit
ResourceCompileinclude directories fromcfg.resincludedirs. - Switch
<ResourceCompile>generation to useresincludedirsinstead of the normal include dir list. - Mirror the same generator change in the embedded built-in scripts blob.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/actions/vstudio/vstudio_vcxproj.lua |
Introduces include_resdirs() and uses it for <ResourceCompile> include paths. |
src/host/scripts.c |
Updates the embedded copy of the VS vcxproj generator script to match the Lua source change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pmackinlay
added a commit
to pmackinlay/mame
that referenced
this pull request
Apr 9, 2026
* local fix for GENie resource include directory bug, sent upstream as bkaradzic/GENie#572 * local fix to disable broken command line escaping * local fix to use MPARAM instead of hard-coded -m64
cuavas
pushed a commit
to mamedev/mame
that referenced
this pull request
Apr 9, 2026
* Local fix for GENie resource include directory bug, sent upstream as bkaradzic/GENie#572 * Local fix to disable broken command line escaping * Local fix to use MPARAM instead of hard-coded -m64
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 12, 2026
* Local fix for GENie resource include directory bug, sent upstream as bkaradzic/GENie#572 * Local fix to disable broken command line escaping * Local fix to use MPARAM instead of hard-coded -m64
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 14, 2026
* Local fix for GENie resource include directory bug, sent upstream as bkaradzic/GENie#572 * Local fix to disable broken command line escaping * Local fix to use MPARAM instead of hard-coded -m64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure about review/approval process, but this fix works for MAME.