Open
Conversation
Contributor
Author
|
So far for today. What do you think of this approach? Cheers. |
KageKirin
force-pushed
the
headeronlylibs-part2
branch
from
58eae85 to
519e47a
Compare
This adds a check and early exit before writing the link command
This adds a check and early exit before writing the link command
This adds a check and early exit before writing the link command
This adds a check and early exit before writing the link command
KageKirin
force-pushed
the
headeronlylibs-part2
branch
from
519e47a to
8c3d805
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is the alternative/part2 of #483 that disables linking altogether when there's nothing to link.
So far, ninja and make have been implemented, and this solution seems way easier to me.
What do you think?
Cheers.