v5.11.3: UX cleanup patch — manage --yes, backup ms-suffix, ICMP+oper FAQ, --psk highlight#64
Merged
v5.11.3: UX cleanup patch — manage --yes, backup ms-suffix, ICMP+oper FAQ, --psk highlight#64
Conversation
added 2 commits
April 28, 2026 15:59
- manage --yes flag + AWG_YES env (skip confirm-prompt for cron/Ansible) - backup filename ms-suffix (.123.tar.gz) — collision protection on rapid-fire - ADVANCED FAQ: ICMP in tunnel (RU+EN, D#63) - oper-to-I1 table extended: Tele2 Krasnoyarsk + Megafon regions (I1=absent fallback) - README highlight for --psk: cheat sheet entry + Shadowrocket FAQ (I#62) - release prep: SCRIPT_VERSION 5.11.2 to 5.11.3, dates 2026-04-28, SHA256 pins refreshed, URL bumps in README/ADVANCED, version badge Tests: +33 bats (294 total, was 261) - test_yes_flag.bats (+11) - test_backup_collision.bats (+8) - test_v5113_docs.bats (+14, Phase 3+4+5 parity) Backwards-compatible: --yes opt-in, default unchanged. Backup ms-suffix coexists with legacy filenames. Downgrade to v5.11.2 is safe.
Two false-positives surfaced by CI's stricter shellcheck -x mode: - test_backup_collision.bats: replace unused loop counter 'i' with '_' - test_yes_flag.bats: shellcheck-disable SC2034 on CLI_YES/AWG_YES assignments — they ARE read inside the eval-extracted confirm_action function body, but shellcheck cannot trace through eval Local 'shellcheck -S warning' on .sh files alone did not catch this because the .bats files were not in scope. Adding -x and including the .bats glob in the local pre-commit check now matches CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UX cleanup patch over v5.11.2 — interactive-command cleanups for cron/Ansible, rapid-backup collision protection, and FAQ extensions answering recent issues/discussions. No architectural changes.
What's in
Code
manage --yesflag +AWG_YES=1env — skips confirm prompts inremove,restore,restart. Opt-in; default behavior unchanged.awg_backup_2026-04-28_15-53-50.123.tar.gz) — collision protection on rapid-fire backups (regen → backup → modify → backup within the same second). Backwards-compatible: legacy backups still match the find pattern.Docs (RU+EN)
ufw allow ... proto icmpis unsupported.I1=absentworkaround, new Megafon (regions) row, AWG 1.0 fallback explainer (I#42 @alkorrnd).--pskhighlight — new Cheat Sheet line + Shadowrocket FAQ entry (I#62 @andreykorobko).Tests
test_yes_flag.bats(+11) — CLI_YES/AWG_YES branches isolated, non-"1"values explicitly rejected under forced-interactive mode.test_backup_collision.bats(+8) — rapid-firedate +%3Ndistinct values, find/sort works on legacy + ms-suffix mix.test_v5113_docs.bats(+15) — Phase 3+4+5 docs invariants, RU/EN cross-link drift guard.Pre-merge checks
bash -ncleansha256sumof helper scriptsrestore, AWG_YES rejection test was masked by non-TTY guard, RU/EN link drift guard too lax). All four addressed in amend.Test plan
bats tests/— 295 PASSshellcheck -s bash -S warning— 0 warnings on all 6 scriptsmanage add testclient --psk— PresharedKey present and matches between client.confand serverawg0.confmanage backup× 2 within same second — two distinct ms-suffix tar filesmanage remove ... --yes </dev/null— works without TTYAWG_YES=1 manage remove ...— env equivalent worksmanage restore <ms-suffix.tar.gz>— round-trip OK, auto-rollback snapshot createdmanage check— Состояние OK, AWG 2.0 параметры активныBackwards compatibility
Fully backwards-compatible.
--yesis opt-in (no behavior change without it). Backup ms-suffix coexists with legacy filenames; restore handles both. Downgrade to v5.11.2 is safe.