Skip to content

Audit ServiceTypeByKey — add Ignored entries for newer Apple entitlements #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Badlazzor wants to merge 1 commit into
base: fix/healthkit-access-entitlement
Choose a base branch
from
Open

Audit ServiceTypeByKey — add Ignored entries for newer Apple entitlements #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions autocodesign/devportalclient/appstoreconnect/capabilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,13 @@ var ServiceTypeByKey = map[string]CapabilityType{
"com.apple.developer.ClassKit-environment": Classkit,
"com.apple.developer.coremedia.hls.low-latency": CoremediaHLSLowLatency,
// does not appear on developer portal
"com.apple.developer.icloud-container-identifiers": Ignored,
"com.apple.developer.ubiquity-container-identifiers": Ignored,
"com.apple.developer.healthkit.access": Ignored,
ParentApplicationIdentifierEntitlementKey: Ignored,
"com.apple.developer.icloud-container-identifiers": Ignored,
"com.apple.developer.ubiquity-container-identifiers": Ignored,
"com.apple.developer.healthkit.access": Ignored,
"com.apple.developer.kernel.extended-virtual-addressing": Ignored,
"com.apple.developer.kernel.increased-memory-limit": Ignored,
"com.apple.developer.authentication-services.credential-provider-ui": Ignored,
ParentApplicationIdentifierEntitlementKey: Ignored,
// These are entitlements not supported via the API and this step,
// profile needs to be manually generated on Apple Developer Portal.
"com.apple.developer.contacts.notes": ProfileAttachedEntitlement,
Expand Down
17 changes: 17 additions & 0 deletions autocodesign/entitlement_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,20 @@ func TestCapability_HealthKitAccessIgnored(t *testing.T) {
require.NoError(t, err)
require.Nil(t, cap)
}

func TestCapability_IgnoredKeys(t *testing.T) {
keys := []string{
"com.apple.developer.kernel.extended-virtual-addressing",
"com.apple.developer.kernel.increased-memory-limit",
"com.apple.developer.authentication-services.credential-provider-ui",
}
for _, key := range keys {
t.Run(key, func(t *testing.T) {
ent := Entitlement(map[string]interface{}{key: true})
cap, err := ent.Capability()
require.NoError(t, err)
require.Nil(t, cap)
require.False(t, ent.AppearsOnDeveloperPortal())
})
}
}