Request arbitration when mediation result is rejected#4657
Open
KimStrand wants to merge 1 commit intobisq-network:mainfrom
Open
Request arbitration when mediation result is rejected#4657KimStrand wants to merge 1 commit intobisq-network:mainfrom
KimStrand wants to merge 1 commit intobisq-network:mainfrom
Conversation
KimStrand
changed the title
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 26 minutes and 27 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (21)
WalkthroughAdds arbitration support and refactors dispute handling: introduces a unified MuSigTradeDispute model, dispute orchestration service, arbitrator services and result signing/verification, updates trader mediation/arbitration services and desktop UI for arbitration state, and adds tests for the dispute flow. Changes
Sequence Diagram(s)sequenceDiagram
participant Desktop as Desktop UI
participant TradeSvc as MuSigTradeService
participant DisputeSvc as MuSigTradeDisputeService
participant ArbitrationTrader as MuSigTraderArbitrationService
participant Network as NetworkService
Desktop->>TradeSvc: onRejectMediation(trade)
TradeSvc->>DisputeSvc: rejectMediationResult(trade)
DisputeSvc->>DisputeSvc: set dispute state -> MEDIATION_CLOSED
DisputeSvc->>ArbitrationTrader: (if conditions) requestArbitration(...)
ArbitrationTrader->>Network: confidentialSend(MuSigArbitrationRequest)
Network-->>ArbitrationTrader: send result
ArbitrationTrader->>DisputeSvc: applyArbitrationStateToChannel(...)
DisputeSvc->>Desktop: update UI / delivery status
sequenceDiagram
participant Confidential as ConfidentialMessageService
participant ArbitratorSvc as MuSigArbitratorService
participant Auth as Banned/Role Authorization
participant Persist as Trade Persistence
Confidential->>ArbitratorSvc: onMessage(MuSigArbitrationRequest)
ArbitratorSvc->>Auth: validate requester not banned & roles match
Auth-->>ArbitratorSvc: authorized / rejected
alt authorized & local identity found
ArbitratorSvc->>Persist: log receipt & process request
else rejected
ArbitratorSvc->>ArbitratorSvc: drop/reject request
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
mu-sig/src/main/java/bisq/mu_sig/MuSigService.java (1)
284-299:⚠️ Potential issue | 🟠 MajorPass
Optional.empty()for thearbitratorparameter instead ofmediator.The arbitrator selection code is deferred (lines 284–290 are commented out), but line 299 currently passes
mediatorfor both the mediator and arbitrator parameters. This is semantically incorrect—these should be independent values. While the arbitrator field is not yet used in the current codebase, storing the mediator'sUserProfilein the arbitrator field is misleading.🔧 Proposed fix
return takerCreatesProtocol(takerIdentity, muSigOffer, takersBaseSideAmount, takersQuoteSideAmount, takersPaymentMethodSpec, takersAccount.getAccountPayload(), mediator, - mediator); + Optional.empty());🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@mu-sig/src/main/java/bisq/mu_sig/MuSigService.java` around lines 284 - 299, The call to takerCreatesProtocol currently passes the same Optional<UserProfile> mediator for both mediator and arbitrator, which is incorrect since arbitrator selection is disabled; update the call in MuSigService to pass mediator for the mediator parameter and Optional.empty() for the arbitrator parameter (i.e., replace the second mediator argument with Optional.empty()) so the arbitrator slot is explicitly empty while keeping mediator unchanged.
🧹 Nitpick comments (4)
trade/src/main/java/bisq/trade/mu_sig/arbitration/MuSigTraderArbitrationService.java (1)
100-116: Consider using descriptive exceptions fororElseThrow()calls.The bare
orElseThrow()calls at lines 100, 111, and 114 will throwNoSuchElementExceptionwithout context, making debugging harder if these fail in production.♻️ Proposed improvement
- MuSigOpenTradeChannel channel = findMuSigOpenTradeChannel(tradeId).orElseThrow(); + MuSigOpenTradeChannel channel = findMuSigOpenTradeChannel(tradeId) + .orElseThrow(() -> new IllegalStateException("No open trade channel found for trade: " + tradeId)); String encoded = Res.encode("muSig.arbitration.requester.tradeLogMessage", channel.getMyUserIdentity().getUserName()); muSigOpenTradeChannelService.sendTradeLogMessage(encoded, channel); muSigOpenTradeChannelService.setDisputeAgentType(channel, MuSigDisputeAgentType.ARBITRATOR); NetworkId arbitratorNetworkId = arbitrator.getNetworkId(); MuSigArbitrationRequest muSigArbitrationRequest = new MuSigArbitrationRequest(tradeId, contract, mediationResult, mediationResultSignature, - userProfileService.findUserProfile(myIdentity.getId()).orElseThrow(), + userProfileService.findUserProfile(myIdentity.getId()) + .orElseThrow(() -> new IllegalStateException("User profile not found for identity: " + myIdentity.getId())), userProfileService .findUserProfile(peer.getNetworkId().getId()) - .orElseThrow(), + .orElseThrow(() -> new IllegalStateException("Peer user profile not found: " + peer.getNetworkId().getId())),🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@trade/src/main/java/bisq/trade/mu_sig/arbitration/MuSigTraderArbitrationService.java` around lines 100 - 116, Replace the bare orElseThrow() calls with descriptive exceptions to provide context when lookups fail: wrap the channel lookup (findMuSigOpenTradeChannel(tradeId)), the my user profile (userProfileService.findUserProfile(myIdentity.getId())), and the peer profile (userProfileService.findUserProfile(peer.getNetworkId().getId())) in orElseThrow(() -> new IllegalStateException("...")) or a domain-specific NotFoundException that includes identifying info (tradeId, myIdentity.getId(), peer.getNetworkId()) so the MuSigArbitrationRequest construction and subsequent calls (muSigOpenTradeChannelService.sendTradeLogMessage, setDisputeAgentType) will fail with clear messages rather than NoSuchElementException.apps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigPendingTTradesUtils.java (1)
87-106: Consider error handling between sequential service calls.Lines 94-95 call
rejectMediationResultfollowed byrequestArbitrationwithout error handling. IfrejectMediationResultthrows an exception, the feedback popup won't show, which may be acceptable. However, ifrejectMediationResultsucceeds butrequestArbitrationfails, the user might be left in an inconsistent state (mediation rejected but no arbitration request sent).This may be acceptable given the existing pattern in
requestMediation, but worth considering whether atomic behavior or retry logic is needed for this escalation flow.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigPendingTTradesUtils.java` around lines 87 - 106, The sequential calls in rejectMediationResultAndRequestArbitration (tradeService.rejectMediationResult then tradeService.requestArbitration) need error handling so a failed requestArbitration doesn't leave the trade half-processed; wrap the requestArbitration call in a try/catch, log the exception and show a user-facing error Popup (and offer retry), and if your service exposes a compensating method (e.g. restoreMediationResult or similar) consider invoking it in the catch to revert the prior rejectMediationResult; ensure tradeService.rejectMediationResult, tradeService.requestArbitration and the Popup feedback logic are updated accordingly.trade/src/main/java/bisq/trade/mu_sig/MuSigTradeDisputeService.java (2)
94-115: Same redundant pattern with arbitrator.Same suggestion applies here: use
arbitrator.get()instead ofarbitrator.orElseThrow()after theisPresent()check.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@trade/src/main/java/bisq/trade/mu_sig/MuSigTradeDisputeService.java` around lines 94 - 115, The code in requestArbitration uses an Optional "arbitrator" that is already checked with arbitrator.isPresent() but then calls arbitrator.orElseThrow() later; replace those orElseThrow() calls with arbitrator.get() to avoid redundant checks and make intent clearer. Update the method requestArbitration in MuSigTradeDisputeService to use arbitrator.get() when passing the arbitrator into muSigTraderArbitrationService.requestArbitration (and ensure any similar uses in that method, e.g., of arbitrator variable) instead of arbitrator.orElseThrow().
66-84: Minor: RedundantorElseThrow()afterisPresent()check.After verifying
mediator.isPresent(), you can safely usemediator.get()instead ofmediator.orElseThrow(). The current code works correctly but the pattern is slightly misleading.♻️ Suggested simplification
public void requestMediation(MuSigTrade trade) { checkArgument(!bannedUserService.isUserProfileBanned(trade.getMyIdentity().getNetworkId())); MuSigContract contract = trade.getContract(); Optional<UserProfile> mediator = contract.getMediator(); if (mediator.isPresent()) { MuSigTradeDispute tradeDispute = trade.getTradeDispute(); MuSigDisputeState current = tradeDispute.getDisputeState(); if (current != MuSigDisputeState.NO_DISPUTE) { log.warn("Cannot request mediation for trade {} because not in the right state.", trade.getId()); return; } tradeDispute.setDisputeState(MuSigDisputeState.MEDIATION_REQUESTED); persist.run(); muSigTraderMediationService.requestMediation(trade.getId(), trade.getMyIdentity(), - trade.getPeer(), mediator.orElseThrow(), contract); + trade.getPeer(), mediator.get(), contract); } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@trade/src/main/java/bisq/trade/mu_sig/MuSigTradeDisputeService.java` around lines 66 - 84, The code in requestMediation uses mediator.orElseThrow() immediately after checking mediator.isPresent(); replace the redundant orElseThrow() with mediator.get() in the call to muSigTraderMediationService.requestMediation so it clearly reflects the prior presence check (update the call in MuSigTradeDisputeService.requestMediation that passes mediator to muSigTraderMediationService.requestMediation).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@apps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigTradeStateController.java`:
- Around line 266-270: The branch in MuSigTradeStateController currently only
treats MuSigDisputeState.MEDIATION_CLOSED as escalation to arbitration; update
the conditional in the method that contains the shown snippet to treat
MuSigDisputeState.MEDIATION_RE_OPENED the same way by checking for both states
(MEDIATION_CLOSED || MEDIATION_RE_OPENED) and calling
MuSigPendingTTradesUtils.rejectMediationResultAndRequestArbitration(trade,
tradeService) for those cases, otherwise keep calling
tradeService.rejectMediationResult(trade).
In
`@support/src/main/java/bisq/support/arbitration/mu_sig/MuSigArbitrationResultService.java`:
- Around line 40-41: Rename the local variable ArbitrationResultHash to
camelCase arbitrationResultHash in MuSigArbitrationResultService within the code
that assigns getArbitrationResultHash(arbitrationResult) and passes it to
SignatureUtil.sign; update both the declaration and its use so the variable name
matches Java conventions (e.g., byte[] arbitrationResultHash =
getArbitrationResultHash(arbitrationResult); return
SignatureUtil.sign(arbitrationResultHash, keyPair.getPrivate());).
In `@trade/src/main/java/bisq/trade/mu_sig/MuSigTradeDispute.java`:
- Around line 142-161: The equals() and hashCode() currently compare the
Observable wrapper (disputeState) instead of the contained MuSigDisputeState
value; update both methods to use the Observable's contained value when
comparing and hashing (e.g., replace disputeState.equals(that.disputeState) with
Objects.equals(disputeState.getValue() / disputeState.get() as appropriate,
that.disputeState.getValue()/get()), and use
Objects.hashCode(disputeState.getValue()/get()) in hashCode) while keeping the
existing comparisons for muSigMediationResult, mediationResultSignature,
muSigArbitrationResult and arbitrationResultSignature unchanged.
---
Outside diff comments:
In `@mu-sig/src/main/java/bisq/mu_sig/MuSigService.java`:
- Around line 284-299: The call to takerCreatesProtocol currently passes the
same Optional<UserProfile> mediator for both mediator and arbitrator, which is
incorrect since arbitrator selection is disabled; update the call in
MuSigService to pass mediator for the mediator parameter and Optional.empty()
for the arbitrator parameter (i.e., replace the second mediator argument with
Optional.empty()) so the arbitrator slot is explicitly empty while keeping
mediator unchanged.
---
Nitpick comments:
In
`@apps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigPendingTTradesUtils.java`:
- Around line 87-106: The sequential calls in
rejectMediationResultAndRequestArbitration (tradeService.rejectMediationResult
then tradeService.requestArbitration) need error handling so a failed
requestArbitration doesn't leave the trade half-processed; wrap the
requestArbitration call in a try/catch, log the exception and show a user-facing
error Popup (and offer retry), and if your service exposes a compensating method
(e.g. restoreMediationResult or similar) consider invoking it in the catch to
revert the prior rejectMediationResult; ensure
tradeService.rejectMediationResult, tradeService.requestArbitration and the
Popup feedback logic are updated accordingly.
In
`@trade/src/main/java/bisq/trade/mu_sig/arbitration/MuSigTraderArbitrationService.java`:
- Around line 100-116: Replace the bare orElseThrow() calls with descriptive
exceptions to provide context when lookups fail: wrap the channel lookup
(findMuSigOpenTradeChannel(tradeId)), the my user profile
(userProfileService.findUserProfile(myIdentity.getId())), and the peer profile
(userProfileService.findUserProfile(peer.getNetworkId().getId())) in
orElseThrow(() -> new IllegalStateException("...")) or a domain-specific
NotFoundException that includes identifying info (tradeId, myIdentity.getId(),
peer.getNetworkId()) so the MuSigArbitrationRequest construction and subsequent
calls (muSigOpenTradeChannelService.sendTradeLogMessage, setDisputeAgentType)
will fail with clear messages rather than NoSuchElementException.
In `@trade/src/main/java/bisq/trade/mu_sig/MuSigTradeDisputeService.java`:
- Around line 94-115: The code in requestArbitration uses an Optional
"arbitrator" that is already checked with arbitrator.isPresent() but then calls
arbitrator.orElseThrow() later; replace those orElseThrow() calls with
arbitrator.get() to avoid redundant checks and make intent clearer. Update the
method requestArbitration in MuSigTradeDisputeService to use arbitrator.get()
when passing the arbitrator into
muSigTraderArbitrationService.requestArbitration (and ensure any similar uses in
that method, e.g., of arbitrator variable) instead of arbitrator.orElseThrow().
- Around line 66-84: The code in requestMediation uses mediator.orElseThrow()
immediately after checking mediator.isPresent(); replace the redundant
orElseThrow() with mediator.get() in the call to
muSigTraderMediationService.requestMediation so it clearly reflects the prior
presence check (update the call in MuSigTradeDisputeService.requestMediation
that passes mediator to muSigTraderMediationService.requestMediation).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ed5b8392-daca-41fd-9003-2eea0193c2d8
📒 Files selected for processing (20)
apps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigPendingTTradesUtils.javaapps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigTradeStateController.javaapps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigTradeStateModel.javaapps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigTradeStateView.javai18n/src/main/resources/authorized_role.propertiesi18n/src/main/resources/mu_sig.propertiesmu-sig/src/main/java/bisq/mu_sig/MuSigService.javasupport/src/main/java/bisq/support/SupportService.javasupport/src/main/java/bisq/support/arbitration/mu_sig/MuSigArbitrationResultService.javasupport/src/main/java/bisq/support/arbitration/mu_sig/MuSigArbitratorService.javasupport/src/main/java/bisq/support/mediation/mu_sig/MuSigMediationResultService.javatrade/src/main/java/bisq/trade/mu_sig/MuSigTrade.javatrade/src/main/java/bisq/trade/mu_sig/MuSigTradeDispute.javatrade/src/main/java/bisq/trade/mu_sig/MuSigTradeDisputeService.javatrade/src/main/java/bisq/trade/mu_sig/MuSigTradeService.javatrade/src/main/java/bisq/trade/mu_sig/arbitration/MuSigTraderArbitrationService.javatrade/src/main/java/bisq/trade/mu_sig/mediation/MuSigTraderMediationService.javatrade/src/main/proto/trade.prototrade/src/test/java/bisq/trade/mu_sig/MuSigTradeDisputeServiceTest.javatrade/src/test/java/bisq/trade/mu_sig/MuSigTradeServiceTest.java
💤 Files with no reviewable changes (1)
- trade/src/test/java/bisq/trade/mu_sig/MuSigTradeServiceTest.java
...va/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigTradeStateController.java
Outdated
Show resolved
Hide resolved
support/src/main/java/bisq/support/arbitration/mu_sig/MuSigArbitrationResultService.java
Outdated
Show resolved
Hide resolved
KimStrand
force-pushed
the
musig-connect-request-arbitration
branch
2 times, most recently
from
42aba1c to
4b9e1c9
Compare
Contributor
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
KimStrand
force-pushed
the
musig-connect-request-arbitration
branch
from
4b9e1c9 to
3070607
Compare
Contributor
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (2)
support/src/main/java/bisq/support/mediation/mu_sig/MuSigMediationResultService.java (1)
44-50: Prefer returningfalseinstead of throwing for hash mismatch in verifier.This path handles untrusted message data; treating mismatch as a normal verification failure keeps semantics consistent with other invalid-signature cases.
♻️ Proposed change
- checkArgument(Arrays.equals(mediationResult.getContractHash(), ContractService.getContractHash(contract)), - "Contract hash from MuSigMediationResult does not match the given contract"); - return verifyMediationResult(mediationResult, mediationResultSignature, publicKey); + if (!Arrays.equals(mediationResult.getContractHash(), ContractService.getContractHash(contract))) { + return false; + } + return verifyMediationResult(mediationResult, mediationResultSignature, publicKey);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@support/src/main/java/bisq/support/mediation/mu_sig/MuSigMediationResultService.java` around lines 44 - 50, The verifier currently uses checkArgument to assert the contract hash match in verifyMediationResult which throws on mismatch; instead treat a hash mismatch as a normal verification failure: replace the checkArgument(Arrays.equals(mediationResult.getContractHash(), ContractService.getContractHash(contract)), ...) with an if check that returns false when the hashes differ so verifyMediationResult (the overload that takes publicKey) is only called for matching hashes and no exception is thrown for untrusted input.trade/src/main/java/bisq/trade/mu_sig/arbitration/MuSigTraderArbitrationService.java (1)
139-145: Unused private method.
findMuSigOpenTradeChannelis defined but never called within this class. Consider removing it to avoid dead code.♻️ Suggested removal
- /* --------------------------------------------------------------------- */ - // Private - /* --------------------------------------------------------------------- */ - - private Optional<MuSigOpenTradeChannel> findMuSigOpenTradeChannel(String tradeId) { - return muSigOpenTradeChannelService.findChannelByTradeId(tradeId); - }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@trade/src/main/java/bisq/trade/mu_sig/arbitration/MuSigTraderArbitrationService.java` around lines 139 - 145, The private helper method findMuSigOpenTradeChannel in MuSigTraderArbitrationService is unused; remove the dead code by deleting the entire method declaration (the method name findMuSigOpenTradeChannel and its body that returns muSigOpenTradeChannelService.findChannelByTradeId(tradeId)); after removal, run a project-wide search to ensure no remaining references to findMuSigOpenTradeChannel exist and update any callers if they were intended to use muSigOpenTradeChannelService directly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@support/src/main/java/bisq/support/mediation/mu_sig/MuSigMediationResultService.java`:
- Around line 44-50: The verifier currently uses checkArgument to assert the
contract hash match in verifyMediationResult which throws on mismatch; instead
treat a hash mismatch as a normal verification failure: replace the
checkArgument(Arrays.equals(mediationResult.getContractHash(),
ContractService.getContractHash(contract)), ...) with an if check that returns
false when the hashes differ so verifyMediationResult (the overload that takes
publicKey) is only called for matching hashes and no exception is thrown for
untrusted input.
In
`@trade/src/main/java/bisq/trade/mu_sig/arbitration/MuSigTraderArbitrationService.java`:
- Around line 139-145: The private helper method findMuSigOpenTradeChannel in
MuSigTraderArbitrationService is unused; remove the dead code by deleting the
entire method declaration (the method name findMuSigOpenTradeChannel and its
body that returns muSigOpenTradeChannelService.findChannelByTradeId(tradeId));
after removal, run a project-wide search to ensure no remaining references to
findMuSigOpenTradeChannel exist and update any callers if they were intended to
use muSigOpenTradeChannelService directly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 4f727cdf-f957-4741-b73b-803ef06e526d
📒 Files selected for processing (20)
apps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigPendingTTradesUtils.javaapps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigTradeStateController.javaapps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigTradeStateModel.javaapps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigTradeStateView.javai18n/src/main/resources/authorized_role.propertiesi18n/src/main/resources/mu_sig.propertiesmu-sig/src/main/java/bisq/mu_sig/MuSigService.javasupport/src/main/java/bisq/support/SupportService.javasupport/src/main/java/bisq/support/arbitration/mu_sig/MuSigArbitrationResultService.javasupport/src/main/java/bisq/support/arbitration/mu_sig/MuSigArbitratorService.javasupport/src/main/java/bisq/support/mediation/mu_sig/MuSigMediationResultService.javatrade/src/main/java/bisq/trade/mu_sig/MuSigTrade.javatrade/src/main/java/bisq/trade/mu_sig/MuSigTradeDispute.javatrade/src/main/java/bisq/trade/mu_sig/MuSigTradeDisputeService.javatrade/src/main/java/bisq/trade/mu_sig/MuSigTradeService.javatrade/src/main/java/bisq/trade/mu_sig/arbitration/MuSigTraderArbitrationService.javatrade/src/main/java/bisq/trade/mu_sig/mediation/MuSigTraderMediationService.javatrade/src/main/proto/trade.prototrade/src/test/java/bisq/trade/mu_sig/MuSigTradeDisputeServiceTest.javatrade/src/test/java/bisq/trade/mu_sig/MuSigTradeServiceTest.java
💤 Files with no reviewable changes (1)
- trade/src/test/java/bisq/trade/mu_sig/MuSigTradeServiceTest.java
✅ Files skipped from review due to trivial changes (1)
- mu-sig/src/main/java/bisq/mu_sig/MuSigService.java
🚧 Files skipped from review as they are similar to previous changes (10)
- support/src/main/java/bisq/support/SupportService.java
- apps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigTradeStateModel.java
- i18n/src/main/resources/mu_sig.properties
- apps/desktop/desktop/src/main/java/bisq/desktop/main/content/mu_sig/trade/pending/trade_state/MuSigPendingTTradesUtils.java
- i18n/src/main/resources/authorized_role.properties
- support/src/main/java/bisq/support/arbitration/mu_sig/MuSigArbitrationResultService.java
- support/src/main/java/bisq/support/arbitration/mu_sig/MuSigArbitratorService.java
- trade/src/main/java/bisq/trade/mu_sig/MuSigTradeDispute.java
- trade/src/main/java/bisq/trade/mu_sig/MuSigTradeDisputeService.java
- trade/src/main/java/bisq/trade/mu_sig/MuSigTradeService.java
KimStrand
force-pushed
the
musig-connect-request-arbitration
branch
from
3070607 to
fabaac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Localization
Tests