-
-
Notifications
You must be signed in to change notification settings - Fork 19
fix(deps): remove unused playwright dependency, clean up install docs #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ff4fc85
docs: move Quick Install before Homebrew and remove Install Browser s…
billy-enrizky 46b4c96
fix(deps): remove playwright from base dependencies
billy-enrizky abb1b03
fix(install): replace playwright CLI fallback with uvx playwright
billy-enrizky 1c130b4
fix(cli): handle daemon auto-start timeout in -c help path
billy-enrizky 218e8fd
fix(cli): graceful error when agent deps missing for TUI/prompt mode
billy-enrizky 823c753
fix: remove broken TUI, bare command now shows help
billy-enrizky fda5e2d
fix: address PR #101 review comments
billy-enrizky a27451b
fix(mcp): skip CDP recovery when no browser session exists
billy-enrizky 18a0a42
fix: address second-round PR review comments
billy-enrizky 82de705
fix(tests): remove invalid DAEMON_DIR patch on daemon server module
billy-enrizky 8dc7e6c
fix(daemon): handle RuntimeError in signal handler registration
billy-enrizky 922fba7
fix(tests): use mock daemon in test_c_with_code_still_works
billy-enrizky feae2be
fix(tests): skip LLM import tests when SDK not installed
billy-enrizky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -161,22 +161,14 @@ if (-not $SkipBrowser) { | |
| } | ||
| catch { | ||
| try { | ||
| $null = Get-Command 'playwright' -ErrorAction Stop | ||
| & playwright install chromium 2>$null | ||
| $null = Get-Command 'uvx' -ErrorAction Stop | ||
| & uvx playwright install chromium 2>$null | ||
| if ($LASTEXITCODE -ne 0) { | ||
| Write-Warn "Chromium install failed (run 'playwright install chromium' manually)" | ||
| Write-Warn "Chromium install failed (run 'openbrowser-ai install' manually)" | ||
| } | ||
| } | ||
| catch { | ||
| try { | ||
| Invoke-Python -Arguments @('-m', 'playwright', 'install', 'chromium') 2>$null | ||
| if ($LASTEXITCODE -ne 0) { | ||
| Write-Warn "Chromium install skipped (run 'openbrowser-ai install' manually)" | ||
| } | ||
| } | ||
| catch { | ||
| Write-Warn "Chromium install skipped (run 'openbrowser-ai install' manually)" | ||
| } | ||
| Write-Warn "Chromium install skipped. Please run 'openbrowser-ai install' manually after installation completes." | ||
| } | ||
|
Comment on lines
+164
to
172
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in fda5e2d. Same generic warning message applied to install.ps1. |
||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The manual browser pre-install command is wrong for the documented
uvxflow;openbrowser-ai installwon't exist unless the package was installed separately.Prompt for AI agents
-> No separate browser install needed. OpenBrowser auto-detects any installed Chromium-based browser (Chrome, Edge, Brave, Chromium) and uses it directly. If none is found and
uvxis available, Chromium is installed automatically on first run. To pre-install manually:openbrowser-ai install+> No separate browser install needed. OpenBrowser auto-detects any installed Chromium-based browser (Chrome, Edge, Brave, Chromium) and uses it directly. If none is found and
uvxis available, Chromium is installed automatically on first run. To pre-install manually (requiresuvx):openbrowser-ai installQuick Start
</file context>