(#2615) use NV_GPU for visible device list#2718
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2615
This pull request improves how device selection and process launching are handled in the training workflow, and adds comprehensive tests to ensure correct behavior in various scenarios. The main changes include normalizing device selection logic, ensuring provider GPU assignments are respected, preventing duplicate accelerator flags, and enhancing test coverage for these cases.
Device selection and environment handling:
_normalize_visible_device_listhelper to robustly parse and validate device lists from environment variables, ensuring consistent device selection logic.NV_GPUorNVIDIA_VISIBLE_DEVICES) as a fallback whenCUDA_VISIBLE_DEVICESis unset, after normalization.Accelerate launch command improvements:
--multi_gputo theaccelerate launchcommand when multiple processes are requested, unless a mutually exclusive accelerator selector (like--use_fsdp) is already present in extra args, preventing duplicate or conflicting flags.Test enhancements:
tests/test_trainer.pyto cover single and multi-GPU selection, provider GPU assignment fallback, and prevention of duplicate accelerator flags, ensuring the new logic is robust and correct. [1] [2] [3]