fix: skip gitignored-dataset tests on CI#47
Merged
benzsevern merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
tests/benchmarks/datasets/ is gitignored, so CI never has the DBLP-ACM files. Two tests (test_autoconfig_parity_pins_unchanged, test_auto_configure_df_dblp_acm_does_not_crash) tried to read them and failed with FileNotFoundError. Now they pytest.skip when the data file is absent. Both tests remain effective on developer machines that have pulled the Leipzig dataset. Parity pin contract is unchanged — the capture script at tests/parity/capture_autoconfig_output.py is still the source of truth for regenerating pins.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two tests added in #44 (
test_autoconfig_parity_pins_unchanged,test_auto_configure_df_dblp_acm_does_not_crash) try to read `tests/benchmarks/datasets/DBLP-ACM/DBLP2.csv`, but that directory is gitignored (`.gitignore:17`). CI fails with `FileNotFoundError`.Fix
Both tests now `pytest.skip` when the dataset file is absent. No behavior change on developer machines that have the data locally.
Test plan