Merge RFC-001: Expression DSL Extension#148
Open
Khanathan wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC-001: Expression DSL Extension
Linked issues
Related to #56
Summary
Adds
rfcs/RFC-001-Expressions.md— an RFC that proposesletting users write streaming transforms in plain Python and
expands the expression DSL with 11 new builtins. No code changes,
RFC only.
What it proposes
@bv.exprdecorator. Write transforms with normal Python:if/elif/else, ternaries,and/or/not,is None,local variables. The decorator translates them into the
existing DSL.
log1p,cliplower,contains,starts_with,ends_with,replaceif_else,is_inhour_of_dayhash_mode.emailas sugar forbv.col("email").a hardcoded
match fn_nameininfer_call_typeonto aninferfn pointer on eachBuiltinFnrow. Compiler enforcescoverage.
CONTRIBUTING-OPS.mdwalking a full op contribution sofuture builtins are good-first-issues.
What it does not change
Expr/Literalvariants. No grammar growth. Nowire-format changes.
Why now
Today's DSL stops at arithmetic, comparisons, and three builtins
(
cast,isnull,quadkey). Users hit the gap on basic shapes(log/clip, lower/contains, hour-of-day, conditional branching)
and route around it with offline Python — losing the windowed
aggregations the server exists to provide. This RFC closes the
gap with the smallest possible surface change and makes future
builtins a one-row append.