Cherry-pick dSYM/debug symbols overhaul from upstream (batch 2)#2913
Draft
luispadron wants to merge 13 commits intomainfrom
Draft
Cherry-pick dSYM/debug symbols overhaul from upstream (batch 2)#2913luispadron wants to merge 13 commits intomainfrom
luispadron wants to merge 13 commits intomainfrom
Conversation
luispadron
force-pushed
the
luis/upstream-batch-2-dsym-overhaul
branch
2 times, most recently
from
a74af8a to
358a9fd
Compare
…les themselves. Cherry-pick: f1ed76b
…rtial along with dead code that was present from use of the vestigial AppleDynamicFrameworkInfo fields. Cherry-pick: 28d227a
…puts and the anticipated base name via use of "fragment_support" and "outputs", shared through compilation_support and linking_support. This will be used to reference the unstripped binary that is found in the generated dSYM bundles. Cherry-pick: c19c91b
…mbols partial. Tests for other platforms and targets besides ios_application will arrive in a following commit. NOTE: includes manual addition of `dsym_variant_flag` since its not public in the upstream code Cherry-pick: 7a0ef14
…e outputs. Add tests for macos_application and macos_command_line_application. Use build_setting_labels flags to reference dsym_variant_flag in test rules when possible. Cherry-pick: b27541a
…ple starlark tests. PiperOrigin-RevId: 752690208
The cherry-pick of upstream commit brought in `bazel_features.cc.objc_fragment_has_builtin_objc_strip_action` which doesn't exist in the open-source build. Use `hasattr(ctx.fragments.objc, "builtin_objc_strip_action")` instead, matching the pattern used elsewhere in the codebase. Also fix `//apple/internal/toolchains:apple_toolchains` to `//apple/internal:apple_toolchains` to match the open-source package layout.
The removal of AppleDynamicFrameworkInfo fields (framework_dirs, framework_files, binary) requires updating the generated docs.
The linking_support struct field was renamed from dsym_binaries to dsym_outputs but not all call sites in the platform rule files were updated, causing analysis failures.
The synced debug_symbols_partial from upstream dropped executable_name, but the open-source build uses it to allow the dSYM filename to differ from bundle_name (e.g. for test bundles). Re-add as an optional param defaulting to None, falling back to bundle_name when unset.
…artial call Missed rename in _ios_app_clip_impl's apple_symbols_file_partial call.
…spaces The synced debug_symbols.bzl from upstream didn't quote OUTPUT_DIR references in shell commands, causing failures for targets with spaces in their bundle names (e.g. ext_with_space). The open-source repo has test targets with spaces that upstream doesn't.
luispadron
force-pushed
the
luis/upstream-batch-2-dsym-overhaul
branch
from
0acea60 to
1302e8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks from the
upstreambranch - batch 2 of a larger sync effort (see #2861 for full context).Stacked on #2912 (batch 1 - linking refactor).
Commits
bin_root_pathreference from dynamic framework provider partial and deadAppleDynamicFrameworkInfofields (upstream: 28d227a)fragment_supportandoutputs(upstream: c19c91b)debug_symbols.bzlwith upstream (full file sync - cherry-pick was not feasible)outputs.dsyms()for new dsymutil bundle outputs, add macOS tests (upstream: b27541a)