fix: Increase brew outdated timeout from 15s to 60s#695
Conversation
Homebrew can be slow depending on network conditions or if it needs to update its index, causing the update check to time out intermittently. Since this is a non-interactive background check, a longer timeout won't impact UX. Fixes #694 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Drew Cain <[email protected]>
|
Claude finished @groksrc's task in 45s —— View job PR Review: Increase brew outdated timeout from 15s to 60s
This is a minimal, well-reasoned fix. Here's the full checklist review: Code Quality & Standards
Testing & Documentation
Basic Memory Architecture
Security & Performance
Compatibility
SummaryApproved. The change is correct and safe. The 60s value is proportionate relative to the other timeouts in the same file ( One minor observation: the constant |
phernandez
left a comment
There was a problem hiding this comment.
I don't know what this does, but sure
|
oh, thats the network timeout. OK. cool |
Summary
BREW_OUTDATED_TIMEOUT_SECONDSfrom 15s to 60s insrc/basic_memory/cli/auto_update.pyFixes #694
Test plan
brew outdatedcheck still works normallyjust fast-check)🤖 Generated with Claude Code