[NFC] Remove dead call to getFirstNonPHI in MergeBB#135
Merged
banach-space merged 1 commit intobanach-space:mainfrom Jan 1, 2026
Merged
[NFC] Remove dead call to getFirstNonPHI in MergeBB#135banach-space merged 1 commit intobanach-space:mainfrom
banach-space merged 1 commit intobanach-space:mainfrom
Conversation
Owner
|
Thank you so much, happy new year! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@banach-space
Summary
Removed a standalone call to
BBSucc->getFirstNonPHI();inMergeBB.cpp.The return value of this function call is ignored, and the function itself has no side effects on the BasicBlock, making this statement a no-op.
Validation
Verified that
MergeBBbuilds successfully.Others
Happy New Year!
By the way