Skip to content

Added support for bucket acl in options. #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkanda wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support for bucket acl in options. #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ req.file('avatar')
secret: 'AB2g1939eaGAdesoccertournament',
bucket: 'my_stuff',
// Optional
token: 'temporary_sts_creds'
token: 'temporary_sts_creds',
acl: 'public-read',
}, function whenDone(err, uploadedFiles) {
if (err) {
return res.serverError(err);
Expand Down
5 changes: 5 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,11 @@ module.exports = function SkipperS3 (globalOpts) {
headers['content-type'] = mime.lookup(__newFile.fd);
}

// Add acl to the headers if it was set in the options.
if (options.hasOwnProperty('acl') && typeof options['acl'] === 'string'){
headers['x-amz-acl'] = options['acl'];
}

var bytesWritten = 0;

var mpu = new S3MultipartUpload({
Expand Down