Skip to content

feat: add support for readthedocs.com domain#11859

Open
CoderQudratov wants to merge 3 commits into
badges:masterfrom
CoderQudratov:master
Open

feat: add support for readthedocs.com domain#11859
CoderQudratov wants to merge 3 commits into
badges:masterfrom
CoderQudratov:master

Conversation

@CoderQudratov
Copy link
Copy Markdown

Fixes #8335

Changes

  • Added domain param to route pattern (org|com)
  • Updated handle() to use dynamic domain (defaults to org)
  • Updated openApi paths to include domain
  • Added tests for .com and explicit .org domain

Testing

  • Existing tests pass (backward compatible)
  • New tests added for readthedocs.com

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Warnings
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code.
Please run tests by including affected services in the pull request title.

⚠️

Found badge URL that may not follow our standard route abbreviations in services/readthedocs/readthedocs.service.js.
Please ensure you've reviewed our conventions.

Messages
📖 ✨ Thanks for your contribution to Shields, @CoderQudratov!

Generated by 🚫 dangerJS against ebe938d

@CoderQudratov
Copy link
Copy Markdown
Author

Hi @chris48s! I've added support for the readthedocs.com domain as discussed. All checks are passing. Could you please review when you get a chance? 🙏

@PyvesB
Copy link
Copy Markdown
Member

PyvesB commented May 15, 2026

Hello @CoderQudratov 👋🏻

A number of changes don't seem related to Read the Docs, please remove them from the PR.

Do any other Read the Docs domains exist (i.e. not readthedocs.com or readthedocs.org)? Is it for example possible to self-host your own Read the Docs instance under an arbitrary domain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Badge Request: Support ReadTheDocs Business Tiers

2 participants