refactor: replace route format with pattern in [website] redirect service#11858
Merged
jNullj merged 1 commit intoMay 14, 2026
Merged
Conversation
Contributor
replace `route`'s deprecated `format` with `pattern` part of badges#3329 helps badges#11800
jNullj
force-pushed
the
refactor-format-into-pattern/website-redirect
branch
from
3fd7e88 to
8ac17f4
Compare
corkumandrew557-tech
approved these changes
May 14, 2026
PyvesB
approved these changes
May 14, 2026
Member
PyvesB
left a comment
PyvesB
left a comment
There was a problem hiding this comment.
This looks fine to me. We are making the path a bit looser (e.g. /website-foo/https/host.svg would previously 404 and now doesn't), but given this is a deprecated redirector, I don't think we should invest too much time in polishing it or making it bullet-proof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace
route's deprecatedformatwithpatternpart of #3329
helps #11800