remote: support explicit local override for PLANNOTATOR_REMOTE#481
Open
foxytanuki wants to merge 1 commit intobacknotprop:mainfrom
Open
remote: support explicit local override for PLANNOTATOR_REMOTE#481foxytanuki wants to merge 1 commit intobacknotprop:mainfrom
foxytanuki wants to merge 1 commit intobacknotprop:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #480
Summary
PLANNOTATOR_REMOTEcurrently only gives explicit meaning to the remote side, sofalse/0still fall through to SSH auto-detection.This PR aligns the runtime and docs around explicit tri-state semantics:
1/trueforces remote mode0/falseforces local modeIt also updates both Bun and Pi runtimes, adds regression coverage, and refreshes the related docs/readmes to match the actual behavior.
Notes
SSH_TTY/SSH_CONNECTIONPLANNOTATOR_REMOTEstill preserves the legacy SSH auto-detect behaviorTesting
bun test packages/server/remote.test.ts packages/server/browser.test.ts apps/pi-extension/server/network.test.ts